Closed marikavertzonis closed 6 years ago
Before introducing complex calculations, basic arrival logic has been implemented. In version 1.0.85 ithe following logic is used, depending on which is reached first:
Now that the location accuracy is shown (as of 1.1) it seems odd that i 'arrive' when i get within 20m of the location, even when my location is being reported with an accuracy of 5m. If horizontal accuracy is available, we should refine our arrival logic to take it into account. Something like:
Show as 'arrived' IF (2 x Horizontal Accuracy) < 20m.
2 x horizontal accuracy would allow for the worst case scenario that you are furthest away from the destination, within the horizontal accuracy. See below diagram for explanation
See #59. Arrival logic has been disabled for version 2.0. However, this can be revisited and finessed if arrival logic is re-enabled in the app.
Rev e10da17 should have been assigned to #31
@marikavertzonis I've reinstated arrival logic based on GPS accuracy. The current scheme is very simple and most likely needs to be improved. Feedback from real world usage is required.
Test with build 3.0.27
Tested 3.0.27 today on iOS while riding a bicycle. Two issues:
The video below shows the test. My destination was my red car. The app thought I had arrived when I was still about 100 meters away from the car. Tested with built-in location (no GNSS receiver) but with a reported accuracy of around 6 meters
Two new tests on 3.0.27
While driving:
While walking:
Some thoughts:
@marikavertzonis @IsmaelInRedlands Arrival logic has been improved. Please test with build 3.0.28
Testing with 3.0.28 on ios (with external gps) and 3.0.29 on android (with internal position source). At walking pace, i 'Arrive' at a distance that corresponds with my accuracy (very nice). More testing tbc.
3.0.28 Built-in GPS on iPhone. 2 Tests with car. Looking good.
@marikavertzonis @IsmaelInRedlands I've added some tweaks to the arrival logic:
Please test with build 3.0.31 and let me know if these features are useful/work as intended.
Testing with 3.0.31 on iphone 8 and pixel 2 at walking and driving pace. the arrival details really pertain to walking pace. this is good. if you're driving, you stop when approaching the site and get out and walk the final part. If there are specific driving arrival requirements, these should be separated into a new issue (or perhaps added to #82)
In this build,
Predictive filtering algorithms should be used to improve navigation and arrival mathematics. Consider Kalman filtering to improve arrival https://en.wikipedia.org/wiki/Kalman_filter