search

Esri / ago-assistant

A swiss army knife for your ArcGIS Online and Portal for ArcGIS accounts
https://ago-assistant.esri.com/
Apache License 2.0
152 stars 89 forks source link

Login button on start page is disabled when lang is Croatian (hr) #142

Open powerslave opened 8 years ago

powerslave commented 8 years ago

console lists missing files

https://ago-assistant.esri.com/js/lib/arcgis/dijit/nls/hr/loading.js 
https://ago-assistant.esri.com/js/lib/arcgis/dijit/nls/hr/common.js 
https://ago-assistant.esri.com/js/lib/arcgis/dijit/form/nls/hr/validate.js

Looks like croatian (hr) lang files are missing, preventing the start page from enabling the login buttons.

similar to issue: https://github.com/Esri/ago-assistant/issues/95

ecaldwell commented 8 years ago

@nheminger Do you know if the hr localization files are available where you pulled the other dojo localizations from?

nheminger commented 8 years ago

@ecaldwell Yes, I can see localization files for hr in the dojo source.

The reason they weren't added was that the missing files referenced in @powerslave console are a different path (dijit) than the CLDR localization files before. It isn't clear to me why for hr these dijit nls resources are required but for the fixing #95 they weren't. My belief is that it is because #95 was dealing with various dialects of english and this isn't and thus dojo needs to pull down internationalization for dijits.

One way to resolve is that I can create a PR with the specific 'hr' resources added from the corresponding dojo version. Then if that fixes the issue, I could add the others for internationalizations so that it isn't just hr that we fix.

powerslave commented 8 years ago

We recently had a similar issue that was fixed by adding hr (and sr) to the localeList in the build profile.

nheminger commented 8 years ago

@powerslave thanks, that might be the cleanest fix. I think the build being used could probably use updating. I think the fastest fix would be to just include the hr and possibly other locales in the file structure. However, long-term I think the cleanest and most optimized would be to add the localeList you mention and create the build again.

ecaldwell commented 8 years ago

There's also a way to specify a fallback locale (i.e. en) in dojoConfig. I'm going to investigate this more. https://dojotoolkit.org/documentation/tutorials/1.10/dojo_config/