Closed sam-berg closed 9 years ago
Good stuff Sam. There's an existing PR (#36). The original issuer has gone dark, but his changes are worthwhile so I'd still like to pull them in. I'll try to evaluate which will be easier to merge last (yours or his). May take a bit of time, so stay tuned and thanks as always for the great contributions.
No guts no glory. This stuff belongs in there. Now I just need to get that other PR cleaned up and merged in with this one.
Look out below! Thanks, Evan... Sam
On Fri, Jun 26, 2015 at 1:31 PM -0700, "Evan Caldwell" notifications@github.com<mailto:notifications@github.com> wrote:
No guts no glory. This stuff belongs in there. Now I just need to get that other PR cleaned up and merged in with this one.
— Reply to this email directly or view it on GitHubhttps://github.com/Esri/ago-tools/pull/39#issuecomment-115873003.
I spent a while in terminal testing merges and rebases between these two PRs. I had it just about sorted out when I realized Github was saying it could still automatically merge the second PR. I pulled the trigger and it all worked flawlessly. Color me impressed.
Evan, these are some utilities that I added and have used. PR for possible inclusion into esri-master per your review:
Samples for each. All supporting code in admin class.