driskull
commented
7 years ago very cool @nicksenger.
I'll go through and take the things that I haven't done yet. Although I rewrote almost all of it and I think its structured a lot better now. Still a few things to do though.
The only other big change is that it provides a scaffold for structuring the application using the js api 4.x widget framework.
I was debating doing this. I'll see what you got.
Most of the boilerplate logic is the same as before, but it's moved from a class to a factory function that returns the boilerplate results as an object literal
Was debating this as well but sticking with a class for now. Since querying for group items still needs a method.
nicksenger
111
@driskull
Hey Matt, I don't expect this to be merged directly but I thought I would put it here since you are in the process of rewriting this boilerplate. It's just some refactoring that made sense in the context of how I'm setting up the embedded group gallery app.
Most of the boilerplate logic is the same as before, but it's moved from a class to a factory function that returns the boilerplate results as an object literal. I tried to clarify the asynchronous requests a bit and also added some error handling (turns out my original issue this morning was with the
PortaItems not firingthen()).The only other big change is that it provides a scaffold for structuring the application using the js api 4.x widget framework.