search

Esri / application-boilerplate-3x-js

Starter application that simplifies the process of building templates for the ArcGIS.com template gallery.
https://developers.arcgis.com/javascript/
Apache License 2.0
90 stars 68 forks source link

GroupID Configured from Application configuration panel is not honoured in Boiler Plate #37

Closed sumitzarkar closed 9 years ago

sumitzarkar commented 9 years ago

Hi @driskull,

@MikeTschudi , @NikkiGolding , @ScottOppmann

If a group template has a default group configured in default.js, then we are seeing that the boiler plate fetches groupinfo and groupitems of this default group even after publishing an app and changing the group using application configuration panel(Displayed on right hand side).

This is occurring since in the code (located at line no 115 in "template.js") all the configs are mixed after getting group info and group items.

So to fix this issue can we mixin "this.config", "this.commonConfig", "this.appConfig" once the app config is available at line no 100 in "template.js".

We have added this code lang.mixin(this.config, this.commonConfig, this.appConfig); at line 100 in template.js and it is solving the issue. Should I send a pull request?

Please let us know if we are missing something obvious.

Thanks, Sumit Zarkar

driskull commented 9 years ago

Hi @sumitzarkar thanks for lettings us know. Yes, please send a pull request if you can. Otherwise, i'll fix it. Thanks again