search

Esri / application-boilerplate-3x-js

Starter application that simplifies the process of building templates for the ArcGIS.com template gallery.
https://developers.arcgis.com/javascript/
Apache License 2.0
90 stars 68 forks source link

GroupID Configured from App values is not honoured in boilerplate #41

Closed sumitzarkar closed 9 years ago

sumitzarkar commented 9 years ago

HI @driskull ,

GroupID Configured from App values is not honoured in boilerplate. This can be fixed by adding following code in the method _queryApplicationConfiguration in template.js at line #382

//Get the groupID from the app values
if (response.itemData.values.group !== "") {
 this.config.group = response.itemData.values.group;
}
driskull commented 9 years ago

hey @sumitzarkar

It looks like it should get mixed into the appConfig property at line 385 which should then be mixed in at line 113 before it queries for the group and items.

Is it not getting into the config property? or is the group an empty string in the app values?

cc @kellyhutchins

sumitzarkar commented 9 years ago

Hi @driskull

Thank you Matt for your reply.

Yes you are correct the groupid is getting mixed in properly. It was my mistake in the application where I was not initialising the boiler plate in proper sequence and the value for groupid configured in the defalut.js was carried forward without being overridden by the appconfiguration.

driskull commented 9 years ago

Thanks @sumitzarkar. We have a pending update that will mix in things a little better.