Esri / application-boilerplate-3x-js

Starter application that simplifies the process of building templates for the ArcGIS.com template gallery.
https://developers.arcgis.com/javascript/
Apache License 2.0
90 stars 68 forks source link

Locally hosted template incorrectly overrides helperServices in default.js #54

Closed jgrayson-apl closed 9 years ago

jgrayson-apl commented 9 years ago

When this template is hosted locally the helperServices settings in default.js are incorrectly overridden in template.js _mixinAll function.

driskull commented 9 years ago

@jgrayson-apl do you see any issue with mixing in the application config or url param values into the config or is it just the organization settings with helper services that you see an issue with?

We could not mix those in but then the developer would have to handle mixing it in or writing something like this:

var url =
this.config.helperServices.geometry.url ||
this.orgConfig.helperServices.geometry.url;

esriConfig.defaults.geometryService = new GeometryService(url);
kellyhutchins commented 9 years ago

@driskull @jgrayson-apl that could be a lot of code that the dev would have to write if they use a bunch of helper services and then we'd have to maintain defaults somewhere and keep them up to date. This is originally why we had the common config. Since we can already skip mixing in the org settings by setting the queryForOrg param to false I'd like to avoid this.

driskull commented 9 years ago

ok. Lets just leave it open and revisit it later.

driskull commented 9 years ago

closing.