Esri / arcade-expressions

ArcGIS Arcade expression templates for all supported profiles in the ArcGIS platform.
Apache License 2.0
278 stars 99 forks source link

Added Popup Sample #5

Closed MKellyEsri closed 6 years ago

MKellyEsri commented 6 years ago

Hyperlinks which pass latatitude and longitude values dynamically

MKellyEsri commented 6 years ago

Thanks for taking a look. Great suggestion - I’ll revise on Monday.

MKellyEsri commented 6 years ago

Just made suggested revisions @ekenes :wink: 2369b38dace2ac31956f4a70cb9364572fd00d5d

ekenes commented 6 years ago

Thanks! Made a few minor formatting updates. Merging...

MKellyEsri commented 6 years ago

Great stuff - thanks @ekenes.

ekenes commented 6 years ago

@MKellyEsri I just tested your webmap and it looks like the link for the Google Pin and the Google Panormaic are the same:

Panoramic: https://www.google.com/maps/@?api=1&map_action=pano&viewpoint= Pin: https://www.google.com/maps/@?api=1&map_action=pano&viewpoint=

var BaseUrl = Decode( EndGoal,
  "Google Directions", "https://www.google.com/maps/dir/?api=1&origin=Current+Location&destination=",
  "Google Panoramic", "https://www.google.com/maps/@?api=1&map_action=pano&viewpoint=",
  "Google Pin", "https://www.google.com/maps/@?api=1&map_action=pano&viewpoint=",
  "Invalid"
);
MKellyEsri commented 6 years ago

Apologies - the Google Pin Url somehow got changed. It's the same in the master: https://github.com/Esri/arcade-expressions/blob/master/popup/url-withlocation.md. Should I open another pull request or do you want to make the change?

The Google Pin BaseUrl needs to be changed to "https://maps.google.com/maps?t=k&q=loc:" in the Decode function.

I have revised the Web Map.

ekenes commented 6 years ago

I'll go ahead and make the change. Thanks!

ekenes commented 6 years ago

Done.