Esri / arcgis-experience-builder-sdk-resources

ArcGIS Experience Builder samples
https://developers.arcgis.com/experience-builder/
Apache License 2.0
125 stars 115 forks source link

Npm install subfolders #174

Open esride-nik opened 8 months ago

esride-nik commented 8 months ago

Added a script in root to scan widget folders for package.json files and npm i all of those. For now, this only concerns react-data-grid, but other widgets might incorporate 3rd party packaged in the future. This is a great way to avoid manually looking for package.jsons in all subfolders.

qlqllu commented 8 months ago

Hi @esride-nik Thanks for your PR! We have added this feature in the latest code, so it'll be available in the next release. Let's keep this PR open until next release to see whether we still need to merge it.

esride-nik commented 6 months ago

Hey @qlqllu, next release is here. What did you mean by "added this feature in the latest code"? Is there a feature in the 1.14 release that does this? If so, I can't find anything about it in the docs.. can you please provide a link?

qlqllu commented 6 months ago

Hi @esride-nik here is the doc link: https://developers.arcgis.com/experience-builder/guide/third-party-libraries/#how-to

esride-nik commented 3 months ago

Hi @qlqllu, I just stumbled upon this during my latest re-install: => "This automatic install will only happen for widgets that are in the your-extensions folder." That's exactly the problem. The "exb-web-extension-repo" is a brilliant feature for any developer working in several projects at the same time. I haven't been using the "your-extensions" folder for years.. It would be great to see ExB natively solve the issue of installing all dependencies for all repos clones into the "client" folder. In the meantime, "npm-install-subfolders" does the job on repository root level.