search

Esri / arcgis-js-cli

CLI to build a template application and widgets using the ArcGIS API for JavaScript
Apache License 2.0
140 stars 31 forks source link

"useDefineForClassFields" in tsconfig.json should be "false" #120

Closed ranga-tolapi closed 9 months ago

ranga-tolapi commented 1 year ago

Hi @odoe, for your attention...

As per Recenter custom widget with Vite... When using Vite 3, "useDefineForClassFields": false needs to be set in tsconfig.json. The ArcGIS JS API requires this setting for the widget's property binding to work.

Description

arcgis-js-cli scaffolded applications currently have "useDefineForClassFields": true.

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

1. 2. 3. 4.

Context

Your Environment

odoe commented 1 year ago

I may just remove the flag entirely, depending on if this functionality is deprecated.

andygup commented 9 months ago

Closing the issue and in preparation for deprecating the library. Plans are in the works for an eventual replacement.