Small refactor on getApi, map snippets and tsConfig

[hhkaos]

I just realized the current tsConfig snippet has some typos (missing commas):

So I fixed it.

Then I tried to make it work but I got this:

I have used another version https://github.com/Esri/jsapi-resources/blob/master/4.x/typescript/demo/tsconfig.json which seems to be similar but with a different target, but it worked for me. Am I doing something wrong?, should we change the target.

Then the tsConfigBasicdidn't work for me either:

So I proposed replaced it with `"target": "es2019",' which fixed it to me.

Cheers!

[hhkaos]

I'm trying and maybe this would be even better:

{
  "compilerOptions": {
    "module": "amd", // output files as AMD modules
    "sourceMap": true,
    "target": "es2019",
    "esModuleInterop": true
  }
}

Does it have any problem? I'm new with TS 😄

[andygup]

I just opened an issue to better doc the minimum req's for TS in the System Requirements doc. Targeting es2019 or higher is currently what we recommend and we'll doc that.

[kellyhutchins]

@hhkaos I think we probably want to keep the jsxFactory and jsx options for those doing widget development but I do think the shorter snippet with es2019 looks good and we should update to that.

[hhkaos]

Great Kelly, I just added the jsxFactory and updated the contributing.md with some of the things we discussed 😄 .