Esri / arcgis-js-vscode-snippets

Collection of Visual Studio Code snippets for common code patterns in the ArcGIS Maps SDK for JavaScript.
https://marketplace.visualstudio.com/items?itemName=Esri.arcgis-maps-sdk-js-snippets
Apache License 2.0
25 stars 8 forks source link

Snippet "description" conventions #21

Closed hhkaos closed 11 months ago

hhkaos commented 3 years ago

Which should be the conventions about the snippet description?

2021-08-05_11-49-54

Screenshot 2021-08-05 at 12 14 16

Ideas/questions about how description should be defined:

kellyhutchins commented 3 years ago

I think yes to both Q1 and Q2 but for Q2 I think if we are going to include the path we should try to come up with an approach to include both AMD and ESM. @andygup do you know if we have info on the # of ESM vs AMD users?

andygup commented 3 years ago

Agreed, it would be good to include both AMD and ESM.

do you know if we have info on the # of ESM vs AMD users?

We are fairly certain that AMD users significantly outnumber ESM users. I can share what number(s) we look at via an internal-only conversation if you want more info.

kellyhutchins commented 3 years ago

@andygup got it. Ok then we can just do amd paths for now and add in (or switch to ESM) at some point in the future.

andygup commented 3 years ago

Oh sorry, I meant I do think we should include both AMD and ESM today and not wait.

One primary pain point for developers using ESM (also speaking for myself 😄 ) is translating AMD module paths, SDK samples and snippets to ESM.