search

Esri / arcgis-js-vscode-snippets

Collection of Visual Studio Code snippets for common code patterns in the ArcGIS Maps SDK for JavaScript.
https://marketplace.visualstudio.com/items?itemName=Esri.arcgis-maps-sdk-js-snippets
Apache License 2.0
25 stars 8 forks source link

Add 2D symbol snippets #5

Closed ekenes closed 3 years ago

ekenes commented 3 years ago

This PR adds JS and TS snippets for 2D symbols and clustering:

It also re-orders all snippets to follow ABC order.

@kellyhutchins will you review?

Since the re-ordering will make it a little difficult to see the new snippets, you can review them here: https://github.com/Esri/arcgis-js-vscode-snippets/commit/fbbb600dda0cc5cd522cb03875dbfdfd57eedccc

If the snippet reordering is too problematic, I can revert that commit and keep this PR only about the new snippets.

cc @RalucaNicola

RalucaNicola commented 3 years ago

@ekenes, I tried out some of the snippets and they work great. Thanks for that, you saved me quite some work!

I have one comment: in the 3D symbol snippets I didn't add const someSymbolName = because maybe the user wants to pass this as an object property or maybe he doesn't like the name you are setting for the symbol variable. I tried to keep the snippet as general as possible so that it works in any situation (same logic as for the imports). So I would personally remove the part where you declare a variable. But let's see what @kellyhutchins thinks as well.

ekenes commented 3 years ago

Good point, @RalucaNicola! I just updated the PR to remove declared vars in these cases.

Is this good to merge, @kellyhutchins?