search

Esri / arcgis-maps-sdk-dotnet-toolkit

Toolkit for ArcGIS Maps SDK for .NET
https://esri.github.io/arcgis-maps-sdk-dotnet-toolkit/
Apache License 2.0
217 stars 121 forks source link

feat(localization): update pseudo translation #557

Closed Isa13169 closed 7 months ago

Isa13169 commented 8 months ago

Updated translation using Jenkins. Please review and merge @dotMorten, @mstefarov

CC: @mich6571 @masa6674

michi6571 commented 8 months ago

@dotMorten We have added new commit to this PR that contains the source update for pluralizations. https://github.com/Esri/arcgis-maps-sdk-dotnet-toolkit/pull/557/commits/a8dbe988391a5acb867904e75e9216f97fd38b6d

@masa6674

michi6571 commented 8 months ago

@dotMorten The translation ETA is 4/2. We will let you know once the new commit is ready.

cc @masa6674

michi6571 commented 7 months ago

This was translated to "website" which is incorrect. I wonder if other languages might have the same issue.

@dotMorten We will review your comment https://github.com/Esri/arcgis-maps-sdk-dotnet-toolkit/pull/557#discussion_r1544893126 and provide you with the update tomorrow.

cc @masa6674

michi6571 commented 7 months ago

This was translated to "website" which is incorrect. I wonder if other languages might have the same issue.

@dotMorten We will review your comment #557 (comment) and provide you with the update tomorrow.

@dotMorten We fixed the issue in LPU and added a new commit to this PR: https://github.com/Esri/arcgis-maps-sdk-dotnet-toolkit/pull/557/commits/45989a5c0d9bbedc985ecfdd1ce9e60ea88aba52

Please review. Thank you.

cc @masa6674

michi6571 commented 7 months ago

This was translated to "website" which is incorrect. I wonder if other languages might have the same issue.

@dotMorten We will review your comment #557 (comment) and provide you with the update tomorrow.

@dotMorten We fixed the issue in LPU and added a new commit to this PR: 45989a5

Please review. Thank you.

Looks like a number of translations got site/website mixed up. We probably need more specific context for the English comments.

@dotMorten @mstefarov Thank you for the review. It looks the some products are using the same string Select a site for "Website". As your comment, if you can consider to use more specific context, it would be helpful to get the appropriate translations for future release.

Please let us know if we can keep the current translations for this release and plan to update for the next release.

cc @jona7150 @masa6674

dotMorten commented 7 months ago

@michi6571 Thanks. There's a comment about this specific one talking about location in facilities. The english word used is also "site" not "website".