[Fix] Editing mode bug in favorites view

des12437 commented 2 months ago

Description

This PR fixes a bug where the "Edit" button in the Favorites view causes other samples to be untappable. The fix sets the environment editing mode to .inactive when the Favorites view is dismissed so that other views that show a list of samples are not displayed with an .active editing mode.

Linked Issue(s)

swift/issues/5405

How To Test

Enter the Favorites category in the Sample Viewer.
Tap the "Edit" button and back out of the category.
Enter another category and verify that the samples can be opened.

philium commented 2 months ago

Alternatively it can be

This isn't doing what you think it is:

It is setting the specified environment value on the list view to inactive, the value of the editMode state property.

Please revert.

des12437 commented 2 months ago

@Esri/swift-samples-reviewers Can someone please give this PR a second review?

Esri / arcgis-maps-sdk-swift-samples