Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 9 forks source link

CertificatePickerViewModel's proceed(withPassword) function's Task.detached be moved inside modifier #249

Open njarecha opened 1 year ago

njarecha commented 1 year ago

See discussion in the PR comment. https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/243/files#r1084508769

dfeinzimer commented 8 months ago

@njarecha can this be closed? Looks like the linked PR failed to auto-close it.

njarecha commented 8 months ago

@dfeinzimer

@njarecha can this be closed? Looks like the linked PR failed to auto-close it.

No, this issue is still not addressed. The link PR suppose to close 241 and this issue is 249.

dfeinzimer commented 8 months ago

Ah yes sorry, got the # mixed up. I'll go ahead and close #241 if that's okay?

njarecha commented 8 months ago

Ah yes sorry, got the # mixed up. I'll go ahead and close https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/issues/241 if that's okay?

Yes, thank you!