Code Refactoring

[mhdostal]

Since the initial completion of the first few components, the best practices and coding style guidelines have evolved. This issue enumerates those changes that should be incorporated across all components.

• @State, @Binding, and other property wrappers should be on the same line as the variable declaration.

• View models should be internal and created by the main component view. Required model properties should be passed in as arguments to the view constructor, with additional properties set via view modifiers.

• Loading a geoModel before being passed to a component and loading a geomodel in a component should be standardized, including the display of loading progress and error(s).

List of components:

• [x] BasemapGallery - PR
  • Associated SwiftAPI issue: #1311
• [x] OverviewMap - PR
• [ ] Search
• [x] Compass
• [x] Floating Panel (?)

[dfeinzimer]

Two things that've just come on my radar that may be worth adding to this list:

1. Disabling Xcode's auto trimming of trailing whitespace (highlighted by @njarecha here). The Swift SDK doesn't seem to trim trailing whitespace.
2. Verifying correct indentation for modifiers on views that are multiline vs views that are single line, also highlighted by Nimesh here.

[mhdostal]

Potential UI/UX improvements:

Overview Map

• Change the massive width segmented control to a nav bar trailing button with context menu to choose between map and scene.

Basemap Gallery

• Minus sign for unloaded map is typically for removing an item. The X is kind of similar for removing an item (home screen tap and hold to remove an app). There are SFSymbols for "! triangle" triangular error and a warning one. ("i" with a triangle badge)
• Can animate "ShowBasemapGallery", slide in from side or out. Would have to be different for Compact popovers are transient, and that may not be what we want if we want users to keep it open to try different basemaps maybe custom

Search

• Change color of subtitle from title (primary and secondary) (foregroundColor(.secondary))
• Maps on iOS has an automatic re-search