Issues found during DocC migration review - Githubissues

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.

https://developers.arcgis.com/swift

Apache License 2.0

29 stars 9 forks source link

Issues found during DocC migration review #406

Closed dfeinzimer closed 7 months ago

dfeinzimer commented 1 year ago

This is a tracking issue for suggestions made during review of #392.

All Components, Examples & Tutorials

[x] Sort all imports (precedent here and here) #689
[x] Preambles with empty lines (see here) #537

Multiple Examples & Tutorials

[x] https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1295059513 #681

`Authenticator`

`BasemapGallery`

`Bookmarks`

`FloatingPanel`

`FloorFilter`

[x] https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1294948228 #478

`OverviewMap`

Example & Tutorial
- [x] https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1295062026 #686

`PopupView`

Example & Tutorial
- [x] #408 Suggestion
Tutorial Only
- [x] #408 Synchronize the tutorial with the example. Changes were made to the example at the very end of the release.

`Scalebar`

[x] https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1294959244 #685

`UtilityNetworkTrace`

Example & Tutorial
- [x] https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/392#discussion_r1295072406 #684

dfeinzimer commented 7 months ago

Closing - all of the feedback mentioned in this issue has been previously resolved, moved into more focused issues with smaller scope or been addressed via a PR linked above.