search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
25 stars 7 forks source link

Synchronize Bundle IDs #423

Open dfeinzimer opened 10 months ago

dfeinzimer commented 10 months ago

We now have IDs defined across the standard examples app, the UI test runner app, the authentication examples app, and soon the JobManager example app. Additionally the toolkit has a bundle ID defined here with capitalization that differs from the others. We should align all of these across the repo to use consistent notation and capitalization.

Location Current ID Proposed ID
Toolkit Bundle Extension com.esri.ArcGISToolkit com.esri.arcgis-swift-sdk-toolkit
Examples App com.esri.arcgis-swift-sdk-toolkit-examples com.esri.arcgis-swift-sdk-toolkit.Examples
Authenticator Example App com.esri.Authentication com.esri.arcgis-swift-sdk-toolkit.AuthenticationExample
JobManager Example App com.esri.JobManagerExample com.esri.arcgis-swift-sdk-toolkit.JobManagerExample
UI Test Runner com.esri.arcgis-swift-sdk-toolkit-ui-test-runner.UITests com.esri.arcgis-swift-sdk-toolkit.UI-Test-Runner
rolson commented 10 months ago

The above is correct for the JobManagerExample bundle identifier. But the logger uses:

return Logger(subsystem: "com.esri.ArcGISToolkit.Examples", category: "JobManagerExample")

That should be sync'ed up in some way when we decide what direction we want to go in.

philium commented 10 months ago

The toolkit bundle identifier follows Apple's practice of using the framework/module name as the last component of the identifier. We also wouldn't want to change the identifier of a released product as that could have unintended consequences.

dfeinzimer commented 4 months ago

We also wouldn't want to change the identifier of a released product as that could have unintended consequences.

@philium would this hold true for a test runner too?