search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 7 forks source link

`FeatureFormView` - Move multiline text editing to a sheet #652

Closed dfeinzimer closed 5 months ago

dfeinzimer commented 5 months ago

Apollo 269

This PR originally augmented the auto-scroll behavior to keep the multiline input caret in view. There're limitations that prevent us from doing it 100% properly without introducing side effects.

By instead removing the text field out of the form's scroll view hierarchy and into a sheet we can take advantage of the natural caret focus behavior afforded to us via init(titleKey: , text: , axis:) (min 16.0).

dfeinzimer commented 5 months ago

Taking back to draft to reconsider some of the changes

dfeinzimer commented 5 months ago

Taking back out of drafts. I switched to trigger off of size changes. This has downsides too. See my author comment on 6e94992.

Overall I'm a little indifferent on merging this.

mhdostal commented 5 months ago

Overall I'm a little indifferent on merging this.

I agree. If we're just trading one issue for another, then it's not worth it. In any case, the workaround is to simply scroll to the cursor.

dfeinzimer commented 5 months ago

@mhdostal The changeover to sheet is complete. Ready for re-review.