Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
28 stars 7 forks source link

200.4.0 package resolution failure #678

Closed dfeinzimer closed 3 weeks ago

dfeinzimer commented 4 months ago

There've been several reports of an issue with resolving the 200.4 package due to Git LFS:

Couldn't check out revision
'a01f570fc225c2ada99913c3430cc42b948075f0':
git-lfs filter-process: git-lfs: command not found
fatal: the remote end hung up unexpectedly
philium commented 4 months ago

Adding symlink to LFS for Xcode

That seems unreasonable for us to expect customers to do, given that Git LFS is only used for testing.

dfeinzimer commented 4 months ago

That seems unreasonable for us to expect customers to do

Agreed and (thankfully?) it seems likely that fix was a false positive. From what I've heard from others and after more of my own testing the failure seems intermittent, with and without the symlink in place.

Edit: I'm going to pull it out of the description for now.

Edit 2: Maybe it's worth noting that simply cloning the repo via command line works consistently.

dfeinzimer commented 4 months ago

Seemingly related issue at https://github.com/apple/swift-package-manager/issues/5351. Discussion on Swift Forums here.

We might need to rethink including LFS for the time being. 🫤

dfeinzimer commented 4 months ago

I've prepared branch df/remove-lfs if we proceed with a patch. Samples is able to checkout this branch without issue.

dfeinzimer commented 4 months ago

A patch has been issued and the release has been re-published and re-tagged.

For anyone experiencing further issues the following files should be removed:

~/Library/Caches/org.swift.swiftpm
~/Library/org.swift.swiftpm
dfeinzimer commented 3 weeks ago

v200.5.0 succeeds 200.4.0 and is available now.