search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
25 stars 7 forks source link

`FeatureFormView` - Attachment handling revisions #729

Closed dfeinzimer closed 1 month ago

dfeinzimer commented 2 months ago

Related Apollo 684

dfeinzimer commented 1 month ago

This is ready for review once again

dfeinzimer commented 1 month ago

Still ready for review. Updated AttachmentFormElement.deleteAttachment(attachment) to AttachmentFormElement.delete(attachment).

mhdostal commented 1 month ago

Updated AttachmentFormElement.deleteAttachment(attachment) to AttachmentFormElement.delete(attachment).

Is that what the new generated code outputs?

mhdostal commented 1 month ago

Does the AttachmentImportMenu.init(element: AttachmentsFormElement, onAdd: ((FeatureAttachment) async throws -> Void)? = nil) method still need the onAdd argument to be async throws?

Same question for onDelete and onRename for the AttachmentPreview class?

dfeinzimer commented 1 month ago

Is that what the new generated code outputs?

It looks like taking the attachments property out of generation to make it not-cached actually caused that.. which I wouldn't have expected. Reverting for now.

mhdostal commented 1 month ago

I think AttachmentFormElement.delete(attachment) is actually better. See the Swift API doc here.