This is my first round of feedback for PR. I see several issues with the code in List-Preplanned-Map-Areas.
This PR addresses several things, but the main issue I see is that status and download action are combined. That means that with the current code, I don't see a way that a download can fail, we can express that to the user, and they can try again. The status needs to be separate from the download button.
Other things it cleans up:
don't need to specify label color parameter for foregroundStyle
renames for clarity
removes excess HStack
separate out some subviews for cleaner body
There is more feedback that I have that revolves around ambiguous status states and errors. Also the model needs to contain the AreaStatus because the view should simply be a function of the model. The view is doing a bit too much there, IMO.
This is my first round of feedback for PR. I see several issues with the code in
List-Preplanned-Map-Areas.This PR addresses several things, but the main issue I see is that status and download action are combined. That means that with the current code, I don't see a way that a download can fail, we can express that to the user, and they can try again. The status needs to be separate from the download button.
Other things it cleans up:
There is more feedback that I have that revolves around ambiguous status states and errors. Also the model needs to contain the
AreaStatusbecause the view should simply be a function of the model. The view is doing a bit too much there, IMO.