search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
25 stars 7 forks source link

Offline: Download preplanned map areas #745

Closed des12437 closed 2 weeks ago

des12437 commented 1 month ago

Closes swift/5357

des12437 commented 1 month ago

If you start downloading a Map area and then hit the refresh button, the status will immediately go to "downloaded" even though it's not yet downloaded.

This issue has been fixed. I will resolve the merge conflicts and re-request review soon.

rolson commented 1 month ago

This issue has been fixed. I will resolve the merge conflicts and re-request review soon.

Is the issue something that a unit test can be added for so we make sure it doesn't regress?

des12437 commented 1 month ago

This issue has been fixed. I will resolve the merge conflicts and re-request review soon.

Is the issue something that a unit test can be added for so we make sure it doesn't regress?

Yes, a unit test can be added to verify that the status equals downloading when the download job is in progress and then the status equals downloaded when the download job succeeds.

rolson commented 1 month ago

This runtime issue should be fixed:

image
des12437 commented 2 weeks ago

@yo1995 This PR is now ready for review.