Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 7 forks source link

`FeatureFormView` - Use `finishEditing` #749

Closed dfeinzimer closed 3 months ago

dfeinzimer commented 4 months ago

Related Apollo 703

  1. submitChanges() -> submitEdits() to balance with discardEdits()
  2. finishEdits() -> finishEditing() to match the function it wraps (FeatureForm.finishEditing())
  3. checkFeatureEditResults() -> [FeatureEditResult].errors
  4. submitEdits() coordinates the full workflow now (as opposed to the chain pattern of submit calling validation, validation calling finish, finish calling apply)
dfeinzimer commented 4 months ago

I'll handle these changes in two parts. Once these changes are approved, I'll update the tutorial to match.

dfeinzimer commented 4 months ago

This is ready for re-review. I've updated the tutorial to match the latest example code.