Small tweaks for new, final, FF Attachments API.

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.

https://developers.arcgis.com/swift

Apache License 2.0

29 stars 7 forks source link

Closed mhdostal closed 3 months ago

mhdostal commented 3 months ago

Build fixes for consuming the final FF Attachments API.

AnyAttachmentsFormInput is now internal.
The FormAttachment.attachment property is now non-nullable, which differs from PopupAttachment.attachment. However, the FeatureForm protocol's attachment property wasn't being used, so it was removed, which eliminated the discrepancy between FormAttachment and PopupAttachment.

mhdostal commented 3 months ago

I was just working on a PR :)

I hope you had essentially the same changes as me!!

dfeinzimer commented 3 months ago

I was just working on a PR :)

I hope you had essentially the same changes as me!!

Yep, was just looking at how to handle the protocol issue.

mhdostal commented 3 months ago

Yep, was just looking at how to handle the protocol issue.

That one was bumming me out, as I didn't see a good way around it. But fortunately, it wasn't used, so could be removed.