Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
25 stars 7 forks source link

Remove unneeded cast #767

Closed dfeinzimer closed 2 weeks ago

dfeinzimer commented 2 weeks ago

https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/pull/758/files#r1649264601

philium commented 2 weeks ago

Remove unneeded cast

Note that this wasn't just an unneeded cast but an unneeded map, which is more significant. The map operation created an entirely new array, adding each element one by one. We are no longer doing any of that unnecessary work.

dfeinzimer commented 2 weeks ago

Note that this wasn't just an unneeded cast but an unneeded map, which is more significant. The map operation created an entirely new array, adding each element one by one.

Good point 👍