search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
25 stars 7 forks source link

FloorFilter: SiteAndFacility Manager appearing when panning map #783

Open bastianmorath opened 1 week ago

bastianmorath commented 1 week ago

When I add a FloorFilter to my map, then open and close the SiteAndFacilitySelector, then the SiteAndFacilitySelector shows again every time the map is panned (see video)

This can be fixed by not using a .constant binding as shown in the following screenshot.

Also, as a sidenote, you do not need to pass the $isSitesAndFacilitiesHidden to all the subviews in order to dismiss the sheet. You can use a '@Environment(.dismiss) private var dismiss' in the corresponding views, which simplifies the code a little bit.

https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/assets/5672716/220d1447-0d45-417b-b178-3f3b286ea37d

image
mhdostal commented 6 days ago

@bastianmorath - Thank you for the issue, especially the detailed explanation; that helps a lot!