Open dfeinzimer opened 3 months ago
@mhdostal and @rolson this is ready for review once again. The updated changes are:
PopupView.popupHeader(_:)
FeatureFormView.formHeader(_:)
PopupView.showCloseButton(_:)
In regards to the suggestion above, would it be better to avoid the complication of maintaining new initializers? With these changes devs can hide the header and easily include a custom one with a VStack
:
.sheet(isPresented: $showPopup) { [popup] in
VStack(alignment: .leading) {
Text(popup!.title)
.font(.title)
PopupView(popup: popup!)
.popupHeader(.hidden)
}
.padding()
}
This is still ready for review. I made one more slight change to avoid breaking the behavior of PopupView.showCloseButton(_:)
.
Closes #835
PopupView.popupHeader(_:)
FeatureFormView.formHeader(_:)
PopupView.showCloseButton(_:)