Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 9 forks source link

`FeatureFormView` & `PopupView` - Add ability to hide default headers #839

Open dfeinzimer opened 3 months ago

dfeinzimer commented 3 months ago

Closes #835

dfeinzimer commented 5 days ago

@mhdostal and @rolson this is ready for review once again. The updated changes are:

In regards to the suggestion above, would it be better to avoid the complication of maintaining new initializers? With these changes devs can hide the header and easily include a custom one with a VStack:

.sheet(isPresented: $showPopup) { [popup] in
    VStack(alignment: .leading) {
        Text(popup!.title)
            .font(.title)
        PopupView(popup: popup!)
            .popupHeader(.hidden)
    }
    .padding()
}
dfeinzimer commented 1 day ago

This is still ready for review. I made one more slight change to avoid breaking the behavior of PopupView.showCloseButton(_:).