search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 9 forks source link

Improve selection logics #867

Closed yo1995 closed 2 months ago

yo1995 commented 2 months ago

Description

For this PR, a few things have been done:

  1. Test if the mmpk files are locked and cannot be deleted when a map created from it is being viewed
    • The result is that the files can be deleted, while the map being viewed cannot show the tiles beyond current LoD. The features can still be shown
    • Upon discussion, this behavior shouldn't be relied upon. Instead, we should disallow deletion when a map is being viewed.
  2. How to go back online?
    • Upon discussion, it is not the component's responsibility to "unselect" a map area and go back to online webmap.
    • Thus, a button is added at the app level to go online to show this workflow.
  3. Disallow opening again or deleting the map when it is being viewed.
yo1995 commented 2 months ago

Ready for review again.

yo1995 commented 2 months ago

Thanks for the feedback!