Closed zkline101 closed 2 months ago
Please wait to review, I see a few more edits I want to make.
@njarecha @dfeinzimer This is now ready for review, thank you.
@zkline101 Please revert the changes of using alerts. There are issues with it. Please see PR where we made the changes from alert
to sheet
.
Dang, alright. The only changes I have then for the trust host prompt and certificate picker is to have the buttons on the top of the sheet.
Thanks @njarecha I reverted the alert changes, this is open for review.
@zkline101 If we are making changes to the credential input view then I would like to see it like this,
instead of this,
@zkline101 If we are making changes to the credential input view then I would like to see it like this,
I would prefer to hold off on making UI edits until we have suggestions from the UI designer who is starting soon.
@dfeinzimer @njarecha @rolson
Ok I moved the buttons back to the original location but kept the Form
. This is ready for review.
iOS:
visionOS:
Just one suggestion. Also, noticed that GeometryReader { proxy in is not used anywhere. Shall we remove it?
Yup looks like that can go. It wasn't used in the original implementation either.
Thanks everyone for the feedback.
cc: @rolson @philium
Swift #6015
These edits were originally meant to give
CredentialInputSheetView
a more native feel on visionOS but then I realized these edits can also apply to iOS and Mac Catalyst. These edits make the credential sheet look more like the credential sheet in the Mail app. I explain more of my changes in the comments below.visionOS before changes:
visionOS after changes:
Apple's credential form in Mail app:
iOS after changes: