search

Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 9 forks source link

`FeatureFormView` / `ComboBoxInput` - Show unsupported values #922

Closed dfeinzimer closed 1 month ago

dfeinzimer commented 1 month ago

Apollo 839

https://github.com/user-attachments/assets/4ed991a6-e349-4c54-8a0b-96118b10880f

dfeinzimer commented 1 month ago

Note that in its current form, this doesn't show the current "Unsupported Type" in the options like Kotlin. Thoughts on this?

dfeinzimer commented 1 month ago

Used map 99ef6889b8ab42eb8cbd3b9672c7b592 / "Extrinsic_Value" to test fallback behavior successfully.

mhdostal commented 1 month ago

Note that in its current form, this doesn't show the current "Unsupported Type" in the options like Kotlin. Thoughts on this?

Is there a reason we're not following what Kotlin does?

dfeinzimer commented 1 month ago

Is there a reason we're not following what Kotlin does?

My original thinking was that it was overcomplicating the sheet content but I can see now how it helps to provide a bit of context around the value being invalid.

I've moved to match Kotlin.

https://github.com/user-attachments/assets/e86704b0-cbc1-4331-b2dd-c91734858dca

https://github.com/user-attachments/assets/0bbba34e-6839-4c2c-9fff-fcc6244bd1e3

dfeinzimer commented 1 month ago

Verified all Feature Form tests pass on iOS 17 and 18 simulators