Esri / arcgis-maps-sdk-swift-toolkit

Mapping components that will simplify your Swift app development with the ArcGIS Maps SDK for Swift.
https://developers.arcgis.com/swift
Apache License 2.0
29 stars 9 forks source link

Utility Network Trace: Programmatic starting points review #925

Closed dfeinzimer closed 1 day ago

dfeinzimer commented 1 month ago

Review the usability and workflow for programatic starting points. Some potential issues:

dfeinzimer commented 1 week ago
  • The component generates graphics, even for programatic points. If the component is closed, those graphics are left on the map.

As the user provides the graphics overlay, they are able to call removeAllGraphics when the component is closed.

  • The purpose of the the add new starting points button becomes unclear...
  • The mapPoint and screenPoint initializer parameters seemingly could also be removed when using programatic starting points.

After checking with Kotlin, the interactive ability to add starting points is always present, even if programatic starting points are used. Thus dropping screenPoint but keeping mapPoint (a Point) aligns us more with Kotlin.