Esri / arcgis-maps-sdk-toolkit-qt

ArcGIS Maps SDK for Qt Toolkit
Apache License 2.0
132 stars 61 forks source link

added Default link to controller and removed last period #516

Closed mrwillyees closed 2 years ago

mrwillyees commented 2 years ago

Removed the ending period . after controller, which was creating a new property in the docs because the qdoc qmlproperty type is different from the coded property (var). image Also, I would like to give more visibility to the cpp controller which is not linked other than on QWidgets but we don't have all the tools implemented as QWidgets, so many controller are only reachable from searching. I was thinking to something like on the qml GUI:

/*!
* \qmlproperty NorthArrowController controller
* . . . 
* A QML default is provided \l [QML] {NorthArrowController} and a CPP is provided \l [CPP] {NorthArrowController}
*/
property var controller : NorthArrowController

But both the links are pointing to the qml implementation, seems that the cpp version is not visible in qml files!

mrwillyees commented 2 years ago

@anmacdonald you might know more on the possibility/impossibility of what I am trying to acheive

anmacdonald commented 2 years ago

Would this work?

* The provided QML default is \l{NorthArrowController} and the provided CPP default is \l{Esri::ArcGISRuntime::Toolkit::NorthArrowController}{NorthArrowController}
mrwillyees commented 2 years ago

@anmacdonald Yea! Works as I was trying to achieve! Do you think is all right to change the controllers properties like this (for the supported ones)?

anmacdonald commented 2 years ago

Yeah that sounds like a very good idea!