search

Esri / arcgis-maps-sdk-toolkit-qt

ArcGIS Maps SDK for Qt Toolkit
Apache License 2.0
132 stars 61 forks source link

Check for undefined basemap gallery thumbnail or tooltip #553

Closed tanneryould closed 2 years ago

tanneryould commented 2 years ago

When loading the Change Basemap sample, the toolkit returns the warnings below. This PR introduces a change to check if the variables are defined before passing them to the modelData, and if they are not, it passes empty strings.

qrc:/esri.com/imports/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryController.qml:135: Error: Cannot assign [undefined] to QUrl
qrc:/esri.com/imports/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryController.qml:135: Error: Cannot assign [undefined] to QString
...
...
...
qrc:/esri.com/imports/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryController.qml:135: Error: Cannot assign [undefined] to QUrl
qrc:/esri.com/imports/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryController.qml:135: Error: Cannot assign [undefined] to QString
ldanzinger commented 2 years ago

@mfeigl can you review? Tanner hit this while testing samples

mfeigl commented 2 years ago

@tanneryould @ldanzinger Apologies, I already had fixed issue today and it's in v.next

mfeigl commented 2 years ago

https://github.com/Esri/arcgis-runtime-toolkit-qt/pull/555

tanneryould commented 2 years ago

@mfeigl I like the ?? notation a bit better but that's fine 😉 Thank you! I'll go ahead and close this then.