Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
399 stars 131 forks source link

Possible bug in tag transfer from outer way to multipolygon relation #117

Closed mboeringa closed 8 years ago

mboeringa commented 8 years ago

Hi Thomas,

We've been working on the proper loading of multipolygon relations and the transfer of tags from outer ways to a multipolygon relation in issues #65 and #72.

Now I encountered a potential issue I hadn't clearly seen or realized before with the latest DLL's you send in December.

What I see happening is that if a key's name ("wetland"), is also a tag value, then this key is not (always?) properly transferred to the multipolygon relation.

E.g. if an outer's tags are: natural=wetland wetland=tidalflat

Then the multipolygon relation will just have: natural=wetland

So the wetland=tidalflat tag is omitted.

EDIT : I now noticed that also other tags (in this case a name=x tag) don't seem to be transferred. In ArcGIS I am seeing the natural=wetland main tag, but neither the wetland=tidalflat and name=x. I do see them on the outer way which is properly set to osmSupportingElement=yes.

A relation where I see this clearly happening is this one: https://www.openstreetmap.org/relation/4430683

Is there a potential fix for this in #110? If not, this definitely needs work, as this type of tagging is quite common. I am actually not entirely sure the issue is caused by the wetland tag, but this is what is a bit peculiar about this polygon's tagging, and I saw the same issue on another wetland feature nearby having the same type of tagging.

See the attached images from within ArcGIS. Don't mind the change in polygon styling: it is the same feature, I just changed styling. Notice how the wetland tag is missing. Also (not visible in the screenshots), as I wrote above, the "name" tag is missing.

wetland_polygon_main_tag wetland_polygon_subtag

mboeringa commented 8 years ago

Great!, thanks. Looking forward to using the latest version of the tools.