search

Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
397 stars 130 forks source link

OSM File Loader (Load only) tool causes coordinate shift with multipolygon processing #142

Closed mboeringa closed 8 years ago

mboeringa commented 8 years ago

Hi @ThomasEmge,

I noticed another issue related to multipolygons: it seems the OSM File Loader (Load only) tool causes a very minor but visible shift in the coordinates of the final output OpenStreetMap multipolyons. Please note that Data Frame's projection was set to the Geographic Coordinate System "WGS1984" during processing. The output coordinate systems for all the Feature Classes created, both for the OSM File Loader (Load only) tool and the Load OSM File tool, were also set to this geographic coordinate system, so no disparities there.

However, could it be that one of the intermediate file geodatabases being created during processing, is using another coordinate system (e.g. Web Mercator), and causing this shift?

See these images:

The first image shows a small section of the output of the OSM File Loader (Load only) for the Polygon layer, these are the outer way and multipolygon of the feature I used as example in issue #141 . Notice the corners of the outer way and multipolygon, don't match up: osm_file_loader_coordinate_shift

The second image shows the output of the Load OSM File tool, with both the osmSupportingElement=yes and no elements on top of each other. Notice that both match up perfectly: load_osm_file_no_coordinate_shift

Lastly, a comparison of the output of the OSM File Loader (Load only) tool compared to the Load OSM File output. The selected feature in blue is the multipolygon of relation r357082 as created by the OSM File Loader (Load only), it is this polygon that is shifted compared to the rest, including the outer way created by the same tool. So it seems the multipolygon creation of the tool is in error: osm_file_loader_coordinate_shift_compare_load_osm_file

mboeringa commented 8 years ago

This is the osm file I used for the testing, as created by the Download OSM Data (XAPI) tool. OSM_Milano.zip

mboeringa commented 8 years ago

Woow, that's quick! ;-). Thanks.