search

Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
395 stars 129 forks source link

Missing "Repair Geometry" step in OSM File Loader (Load only) tool #149

Closed mboeringa closed 8 years ago

mboeringa commented 8 years ago

Hi @ThomasEmge ,

I have now attempted to load both the Netherlands and Denmark with the latest build of the OSM File Loader. However, when I rendered the data, I noticed issues with the display of some of the Polygon geometries in the Denmark dataset.

I then ran the Repair Geometry tool against the data, and this revealed close to 10000 faulty geometries on the Denmark dataset, primarily, but not exclusively, "ring order issues". The latter not surprisingly, as they directly relate to the non-compulsory ring order in OSM datasets and multipolygons or closed ways defined as "area" via the area key. I don't know yet how many geometries are bad in the Netherlands import, because the Repair Geometry step is only half way, but I do some issues listed in the progress dialog (which only shows a fraction, the rest is written to a text file at the end of the process).

Did you accidentally comment out a Repair Geometry step in the latest build, that needs to be activated again?

ThomasEmge commented 8 years ago

The step is still in there, but one of the helper classes had expired.

mboeringa commented 8 years ago

OK, thanks, I'll close this then.