Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
395 stars 129 forks source link

OSM File Loader (Load only) doesn't add feature classes to map #159

Open mboeringa opened 7 years ago

mboeringa commented 7 years ago

Hi @ThomasEmge,

This is a really minor issue, as it can be fully overcome by manually adding the datasets after running the tool, but the OSM File Loader (Load only) tool doesn't add the created Polygon, Polyline and Point feature classes to the ArcMap document if run from within ArcMap. The "old" Load OSM File used to do that, and, in fact, the new tool also shows a progress dialog message "Adding outputs to map", yet fails to do this. Also, this message appears way to early, it already shows when the nodes have just been loaded or so, meaning there is still a long way to go processing the ways and relations.

ThomasEmge commented 7 years ago

So the geoprocessing environment settings from the application are ignored?

mboeringa commented 7 years ago

So the geoprocessing environment settings from the application are ignored?

Can you explain a bit more what you mean? I don't see the relation with adding the output Feature Classes to the ArcMap Data Frame?

ThomasEmge commented 7 years ago

When you go through the menu structure Geoprocessing > Geoprocessing Options... you can define how the results are handled within the application.

image

When checking the highlighted option, the results are added to the table of contents view.

mboeringa commented 7 years ago

@ThomasEmge : I see an even weirder behaviour: when I select the option you pointed out and run the OSM File Loader (Load only) tool, not only are the datasets not being added, the option is also de-selected afterwards when the tool finishes?...

Can you reproduce that?

ThomasEmge commented 7 years ago

Hmm, I did a test run in ArcMap and the 3 feature classes were added to the TOC and the option stayed selected.

mboeringa commented 7 years ago

@ThomasEmge

I have never once seen them being added automatically. It does happen with the old Load OSM File tool. That tool properly follows the Geoprocessing Options setting.

Not so the OSM File Loader (Load only) tool. I have now even saved the ArcMap document, closed it, re-opened it and checked the "Add results" option was checked, and subsequently run the tool.

The option is auto - de-selected after the tool is finished... ;-( No idea what is going on.