Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
395 stars 129 forks source link

editing geometry and atribute #167

Closed cpedrezuela closed 5 years ago

cpedrezuela commented 7 years ago

Hi guys,

I'm on 10.3 and using ArcGIS OSM Editor. Just noticed that I can only change or edit geometry when I remove OSM Editor Extension. Is this the workflow when changing geometry. If I have OSM Extension Editor On, I get an error saying that the geometry is part of a relationship and therefore the edit is not allowed, or something like that. Does this mean that Editor Extension is purely for editing OSM attribute\tags? Also what if I split a geometry first and then enable the Editor and attribute the two segments differently, will those be uploaded to the OSM master db?

Thanks

mboeringa commented 7 years ago

You are probably attempting to edit an OSM multipolygon relation. Note that, even in OSM's main edit database to which all editors (this one, iD, JOSM) post their data, multipolygons DO NOT exist as a true geometry, only nodes, ways and relations are stored there. This may be a surprise to you, but only the relation information is stored there for multipolygons (which nodes and ways belong to the relation with what roles, e.g. "inner" or "outer" way).

Like with data imported through osm2pgsql in PostgreSQL, multipolygons imported by the Editor, are derived features / geometries. They are created only at the moment you import or download&import the data, this is what osm2pgsql also does when creating a render database.

This means these imported multipolygon features should and can not be edited as such, because they don't exist in the OSM main database, you need to edit the primitives of which they consist (nodes and ways as defined in the relation), instead.

So this explains why removing the Editor extension allows you to edit the "multipolygon", which from that moment on is just an ordinary ArcGIS geometry, and no longer an OSM multipolygon relation, because the relation information (or the connection to it), is essentially lost.

If you wonder why iD and JOSM do allow "multipolygon geometries" to be edited: this is not actually the case, it just seems so, you are always editing the nodes, ways, or relation info through the dialogs and screens in these editors, so while it appears you are editing the "multipolygon" as a single contained geometry, you aren't.

cpedrezuela commented 7 years ago

Hi mboeringa, I was editing the line feature. It is a cycleway actually. it wouldn't let me move a vertex or split the line if the editor extension is enabled. I can modify the line once I remove the arceditor extension.

ThomasEmge commented 5 years ago

When you remove the osm extension before you start editing, then no 'tracking' of the edits occurs and hence nothing will get uploaded to the server.