search

Esri / arcgis-osm-editor

ArcGIS Editor for OpenStreetMap is a toolset for GIS users to access and contribute to OpenStreetMap through their Desktop or Server environment.
Apache License 2.0
395 stars 129 forks source link

(Multi)polygon fixing effort #170

Open joto opened 7 years ago

joto commented 7 years ago

There is a major effort going on to fix broken (multi)polygons in OSM and also to finally get rid of old-style multipolygon relations. This will hopefully lead to simpler and more efficient software. There is no immediate need for you to change anything in the ArcGIS OSM editor, but I would expect there to be opportunities to simplify your code and generally make life easier for you once this effort is successful.

I wanted to make you aware of the effort and get you involved in the discussions. We'd also appreciate it if you can support this effort in any way. Find all the details at http://area.jochentopf.com/. We are coordinating with other software project through our issue osmlab/fixing-polygons-in-osm#23.

mboeringa commented 7 years ago

Hi Jochen,

In regard to the joto/fixing-polygons-in-osm#23 issue:

I don't work for ESRI, so this is just my "2 cents worth" as an experienced user of ESRI software and developer, but there is a few main aspects regarding this and ESRI OSM tools:

The Editor is a kind of exception in the OSM world of editors, as it both stores data to be edited, and derived Multipolygon data suitable for rendering of OpenStreetMap data extracts (similar to osm2pgsql import). It is a kind of hybrid database model / schema.

The multipolygon or relation data cannot be edited directly, only viewed and rendered.

I have actually worked closely with ESRI, by supplying bug reports and doing significant rendering testing, to help implement proper old and new style multipolygon support. Since last year (2016), the support is now at a level that is very close to, or rivals, osm2pgsql, meaning rendering output can look very similar.

That said, I fully support your effort to clean up and strengthen new style multipolygon support in the OSM database, editors and tools.

Nonetheless, given the current state of the multipolygon support in the Editor, and all the work to achieve it, I don't think this support should be dropped anytime soon (as you also mentioned is unnecessary).

If anything needs to be done in the future, I would be strongly in favor of a code switch or option to choose between an optimized import process without "old style" multipolygon support, and the current implementation for both old and new style multipolygons.

ThomasEmge commented 7 years ago

Thanks @joto for the creating the issue. I don't think we'll have immediate code changes in the editor. As Marco mentioned, we don't support changing loaded relations. As part of the import process the tools might find themselves changing the tags to be more inline with your suggestions and/or changing some of the geometry topology to match the esri model (https://github.com/Esri/geometry-api-java/wiki). We will keep this issue open to allow for old vs. new discussions as needed.