search

Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
347 stars 120 forks source link

fix(arcgis-rest-routing): solveRoute rawResponse #1046

Open gavinr opened 1 year ago

gavinr commented 1 year ago

fixed issue with solveRoute failing when using rawResponse: true

1045

codecov[bot] commented 1 year ago

Codecov Report

Merging #1046 (f65a64d) into main (805844b) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1046   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         2924      2928    +4     
  Branches       527       528    +1     
=========================================
+ Hits          2924      2928    +4
Impacted Files Coverage Δ
packages/arcgis-rest-routing/src/solveRoute.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gavinr commented 1 year ago

@patrickarlt I checked those other two cases, and they are actually already correctly working: https://github.com/Esri/arcgis-rest-js/issues/1045#issuecomment-1424823159.

I did add a unit test to cover rawResponse with originDestinationMatrix.

Unless I hear any objections I will go ahead and merge this.