search

Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
353 stars 119 forks source link

Set Referer #1059

Closed gavinr closed 1 year ago

gavinr commented 1 year ago

One possible solution (with unit test) to #1058

patrickarlt commented 1 year ago

@gavinr I think this approach is fine. You should add referer to ISignInOptions too though https://github.com/Esri/arcgis-rest-js/blob/367a49c56daa07e09665e43454a80ae6600534f5/packages/arcgis-rest-request/src/ArcGISIdentityManager.ts#L63

codecov[bot] commented 1 year ago

Codecov Report

Merging #1059 (81c2de8) into main (367a49c) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1059   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          147       147           
  Lines         2895      2897    +2     
  Branches       524       525    +1     
=========================================
+ Hits          2895      2897    +2
Impacted Files Coverage Δ
...s/arcgis-rest-request/src/ArcGISIdentityManager.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gavinr commented 1 year ago

Thanks! I added referer to ISignInOptions.