search

Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
347 stars 120 forks source link

Typescript definition for IWebmap in v4 #1079

Closed bamse16 closed 1 year ago

bamse16 commented 1 year ago

Describe the problem

Hello,

I'm trying to migrate a Typescript project using @esri/arcgis-rest-* from v3 to v4.

In the process of converting the existing types, I couldn't find the definition for IWebmap.

Is there a plan to bring that back? What's the migration path for projects using Typescript?

Thank you

Describe the proposed solution

Add IWebmap type to v4.

patrickarlt commented 1 year ago

Hi @bamse16 we decided to remove the web map types at 4.0. We simply got too many issues about missing/incorrect types and the webmap types aren't actually used anywhere in REST JS and generally fell outside the scope of the project.

You can however continue to use @esri/arcgis-rest-types at version 3.6.0 with the rest of ArcGIS REST JS 4.0. Just know that we aren't going to be updating the types.

bamse16 commented 1 year ago

Not adding types going forward works fine to you, however it does not work out for those using the API with TypeScript (node.js or React).

I hope you'll reconsider and keep those packages up to date, so people would not be discouraged to upgrade to 4.x.