Closed yida-tong closed 1 year ago
@noahmulfinger thanks for your review! Changes have been made.
@gr-maps thanks for your inputs!
Demo README added. Please review at your convenience.
About second point, have you tried npm run build
at root level? Seem like missing @esri/arcgis-rest-developer-credentials/
in node_modules folder. Let me know feedback.
About third point, cdn script/stylesheet doesn't occupy package size in my opinion. I would prefer to put that task later if it is not too urgent. I am open to discuss.
@patrickarlt OAuth app task done.
Branch coverage can't reach to 100% even though all test cases are carefully designed.
Add @noahmulfinger @gr-maps @all-reviewers, please re-review at your convenience. Thanks!
Merging #1111 (cf77679) into main (170c450) will not change coverage. Report is 1 commits behind head on main. The diff coverage is
100.00%
.:exclamation: Current head cf77679 differs from pull request most recent head 94e055d. Consider uploading reports for the commit 94e055d to get more accurate results
@@ Coverage Diff @@
## main #1111 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 163 177 +14
Lines 3003 3239 +236
Branches 534 549 +15
==========================================
+ Hits 3003 3239 +236
Files Changed | Coverage Δ | |
---|---|---|
packages/arcgis-rest-portal/src/items/create.ts | 100.00% <ø> (ø) |
|
...gis-rest-developer-credentials/src/createApiKey.ts | 100.00% <100.00%> (ø) |
|
...s-rest-developer-credentials/src/createOAuthApp.ts | 100.00% <100.00%> (ø) |
|
...gis-rest-developer-credentials/src/deleteApiKey.ts | 100.00% <100.00%> (ø) |
|
...s-rest-developer-credentials/src/deleteOAuthApp.ts | 100.00% <100.00%> (ø) |
|
...arcgis-rest-developer-credentials/src/getApiKey.ts | 100.00% <100.00%> (ø) |
|
...-rest-developer-credentials/src/getOAuthAppInfo.ts | 100.00% <100.00%> (ø) |
|
...ges/arcgis-rest-developer-credentials/src/index.ts | 100.00% <100.00%> (ø) |
|
...developer-credentials/src/shared/enum/PRIVILEGE.ts | 100.00% <100.00%> (ø) |
|
...per-credentials/src/shared/getRegisteredAppInfo.ts | 100.00% <100.00%> (ø) |
|
... and 5 more |
Please review:
Test cases are fully covered. If I miss some test aspects, let me know too.