Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
347 stars 120 forks source link

feat(arcgis-rest-portal): add searchCommunityUsers method to allow fo… #1120

Closed rweber-esri closed 1 year ago

rweber-esri commented 1 year ago

1119

V3

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1771794) 100.00% compared to head (d98f512) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1120 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 143 143 Lines 2449 2455 +6 Branches 434 435 +1 ========================================= + Hits 2449 2455 +6 ``` | [Files Changed](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri) | Coverage Δ | | |---|---|---| | [...kages/arcgis-rest-portal/src/users/search-users.ts](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri#diff-cGFja2FnZXMvYXJjZ2lzLXJlc3QtcG9ydGFsL3NyYy91c2Vycy9zZWFyY2gtdXNlcnMudHM=) | `100.00% <100.00%> (ø)` | | | [...ages/arcgis-rest-portal/src/util/generic-search.ts](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri#diff-cGFja2FnZXMvYXJjZ2lzLXJlc3QtcG9ydGFsL3NyYy91dGlsL2dlbmVyaWMtc2VhcmNoLnRz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rweber-esri commented 1 year ago

My only concern is what base branch this should be against. I am guessing that since you want this in hub, and hub is still on 3.x, that you want it to go into a 3.x release. I know main is for 4.x. I forget what the intent of the master branch is, but I recall at some point we were using it for 3.x, maybe while 4.x was under development? I see that there are commits to the 3.x branch that are more recent than the latest commit on master.

Thanks for the input @tomwayson, you are correct, I want the changes on this branch published under 3.x. @dbouwman @gavinr @patrickarlt can you verify what the correct branch is for publishing changes under v3 (master vs 3.x)?

tomwayson commented 1 year ago

This is now released as 3.7.0