Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
347 stars 119 forks source link

Fix documentation for updateUserMemberships function, closes #1124 #1132

Closed alhridoy closed 11 months ago

alhridoy commented 11 months ago

This pull request addresses issue #1124. The documentation for the updateUserMemberships function was incorrect, suggesting the use of admins as a parameter, while the correct parameters are users and newMemberType.

The comments in the code have been updated to reflect the correct usage of the function. This should ensure that the automatically generated documentation is now correct.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (33aba89) 100.00% compared to head (1b2490e) 100.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1132 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 177 177 Lines 3245 3245 Branches 550 550 ========================================= Hits 3245 3245 ``` | [Files](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri) | Coverage Δ | | |---|---|---| | [...s-rest-portal/src/groups/update-user-membership.ts](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri#diff-cGFja2FnZXMvYXJjZ2lzLXJlc3QtcG9ydGFsL3NyYy9ncm91cHMvdXBkYXRlLXVzZXItbWVtYmVyc2hpcC50cw==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.