search

Esri / arcgis-rest-js

compact, modular JavaScript wrappers for the ArcGIS REST API
https://developers.arcgis.com/arcgis-rest-js/
Apache License 2.0
354 stars 119 forks source link

chore: change postal and postalExt to string #1135

Closed BrunoCaimar closed 1 year ago

BrunoCaimar commented 1 year ago

Fix #1094

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9ec89a2) 100.00% compared to head (2d97b4f) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1135 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 177 177 Lines 3245 3247 +2 Branches 550 551 +1 ========================================= + Hits 3245 3247 +2 ``` | [Files](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri) | Coverage Δ | | |---|---|---| | [packages/arcgis-rest-geocoding/src/bulk.ts](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri#diff-cGFja2FnZXMvYXJjZ2lzLXJlc3QtZ2VvY29kaW5nL3NyYy9idWxrLnRz) | `100.00% <ø> (ø)` | | | [packages/arcgis-rest-geocoding/src/geocode.ts](https://app.codecov.io/gh/Esri/arcgis-rest-js/pull/1135?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Esri#diff-cGFja2FnZXMvYXJjZ2lzLXJlc3QtZ2VvY29kaW5nL3NyYy9nZW9jb2RlLnRz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BrunoCaimar commented 1 year ago

Changed to accept string or number. Also, added tests to cover the change.