Esri / arcgis-runtime-samples-ios

Swift samples demonstrating various capabilities of ArcGIS Runtime SDK for iOS
https://developers.arcgis.com/ios
Apache License 2.0
324 stars 394 forks source link

Generate offline map (basemap by reference) bug #1083

Open vquach2404 opened 3 years ago

vquach2404 commented 3 years ago

While updating the TPK for this sample, I found that the sample does not behave as expected. This sample should prompt the user to select either a local or online basemap. However, the sample currently does not prompt the user.

yo1995 commented 3 years ago

Currently this filename is an empty string

https://github.com/Esri/arcgis-runtime-samples-ios/blob/61c82de7f8d620cf7edb54e509f98c2f0606a713/arcgis-ios-sdk-samples/Maps/Generate%20offline%20map%20(basemap%20by%20reference)/GenerateOfflineMapBasemapByReferenceViewController.swift#L74

image

The doc is a bit confusing, but I think there are 2 possibilities

parameters.referenceBasemapFilename = url.lastPathComponent
parameters.referenceBasemapDirectory = url.deletingLastPathComponent()

imagery-tile

The second idea gives me the result above, but I can not tell if it is expected. 😓

yo1995 commented 2 years ago

Do you think this bug is still worth fixing? If not, let's close all the remaining opened issues. 🙂