search

Esri / calcite-app-components

A collection of calcite components for building single page applications
https://esri.github.io/calcite-app-components/
Other
39 stars 10 forks source link

Bug: calcite-pick-list-item is always using the circleF icon even when not selected #1042

Closed kevindoshier closed 4 years ago

kevindoshier commented 4 years ago

Summary

calcite-pick-list-item is always using the circleF icon even when not selected

image

If I construct a calcite-pick-list-item, and set "selected" to false, then this is reproduceable, this was working before, but I installed a change in the app to not set that attribute to false, only set it when its true.

cc: @AdelheidF

Actual Behavior

Expected Behavior

Reproduction Steps

1.

Relevant Info

kevindoshier commented 4 years ago

Also, I create these programatically using document.createElement("calcite-pick-list-item") which might have exposed this issue

jcfranco commented 4 years ago

@kevindoshier Is it also displaying the icon? The list item will hide it via CSS. If it is visible, can you share a snippet showing how you're using list items programmatically?

jcfranco commented 4 years ago

This is working as expected: setting the property to true/false or adding/removing the selected attribute works properly.